1+++
 2title = "Privado: PC-Crawler evaluation"
 3date = 2020-03-04T00:00:23+00:00
 4updated = 2020-03-18T09:39:27+00:00
 5+++
 6
 7As the student `a(i)` where `i = 9`, I have been assigned to evaluate students `a(i + 3)` and `a(i + 4)`, these being:
 8
 9* a12: Classmate (username)
10* a13: Classmate (username)
11
12## Classmate’s evaluation
13
14**Grading: B.**
15
16I think they mix up a bit their considerations with program usage and how it works, not justifying why the considerations are the ones they chose, or what the alternatives would be.
17
18The implementation notes are quite well-written. Even someone without knowledge of Java’s syntax can read the notes and more or less make sense of what’s going on, with the relevant code excerpts on each section.
19
20Implementation-wise, some methods could definitely use some improvement:
21
22* `esExtensionTextual` is overly complicated. It could use a `for` loop and Java’s `String.endsWith`.
23* `calcularFrecuencia` has quite some duplication (e.g. `this.getFicherosYDirectorios().remove(0)`) and could definitely be cleaned up.
24
25However, all the desired functionality is implemented.
26
27Style-wise, some of the newlines and avoiding braces on `if` and `while` could be changed to improve the readability.
28
29The post is written in Spanish, but uses some words that don’t translate well («remover» could better be said as «eliminar» or «quitar»).
30
31## Classmate’s evaluation
32
33**Grading: B.**
34
35Their post starts with an explanation on what a crawler is, common uses for them, and what type of crawler they will be developing. This is a very good start. Regarding the post style, it seems they are not properly using some of WordPress features, such as lists, and instead rely on paragraphs with special characters prefixing each list item.
36
37The post also contains some details on how to install the requirements to run the program, which can be very useful for someone not used to working with Java.
38
39They do not explain their implementation and the filename of the download has a typo.
40
41Implementation-wise, the code seems to be well-organized, into several packages and files, although the naming is a bit inconsistent. They even designed a GUI, which is quite impressive.
42
43Some of the methods are documented, although the code inside them is not very commented, including missing rationale for the data structures chosen. There also seem to be several other unused main functions, which I’m unsure why they were kept.
44
45However, all the desired functionality is implemented.
46
47Similar to Classmate, the code style could be improved and settled on some standard, as well as making use of Java features such as `for` loops over iterators instead of manual loops.