M HISTORY.md → HISTORY.md

@@ -1,3 +1,7 @@
+## 0.1.5 (2009-11-17)
+
+* Actually, if we can't render a thing then don't. Not once, not never.
+
 ## 0.1.4 (2009-11-17)
 
 * Bugfix: Missing commands return the input (instead of nothing)

M lib/github/markup.rb → lib/github/markup.rb

@@ -27,9 +27,11 @@
     def command(command, regexp, &block)
       command = command.to_s
 
-      if !File.exists?(command) && !command.include?('/')
-        command = File.dirname(__FILE__) + '/commands/' + command.to_s
+      if File.exists?(file = File.dirname(__FILE__) + "/commands/#{command}")
+        command = file
       end
+
+      return if !system("which #{command} > /dev/null")
 
       add_markup(regexp) do |content|
         rendered = execute(command, content)
@@ -55,8 +57,6 @@ nil
     end
 
     def execute(command, target)
-      return target if !system("which #{command} > /dev/null")
-
       out = ''
       Open3.popen3(command) do |stdin, stdout, _|
         stdin.puts target

M test/markup_test.rb → test/markup_test.rb

@@ -30,8 +30,16 @@
   def test_fails_gracefully_on_missing_commands
     GitHub::Markup.command(:i_made_it_up, /mde/)
     text = 'hi there'
-    assert_equal true, GitHub::Markup.can_render?('README.mde')
+    assert_equal false, GitHub::Markup.can_render?('README.mde')
     actual = GitHub::Markup.render('README.mde', text)
+    assert_equal text, actual
+  end
+
+  def test_fails_gracefully_on_missing_env_commands
+    GitHub::Markup.command('/usr/bin/env totally_fake', /tf/)
+    text = 'hey mang'
+    assert_equal false, GitHub::Markup.can_render?('README.tf')
+    actual = GitHub::Markup.render('README.tf', text)
     assert_equal text, actual
   end
 end