GBA I/O: Stop logging several harmless invalid register reads
Vicki Pfau vi@endrift.com
Sun, 29 Dec 2019 16:42:10 -0800
2 files changed,
5 insertions(+),
4 deletions(-)
M
CHANGES
→
CHANGES
@@ -107,6 +107,7 @@ - Qt: Fix undesired screen filtering when paused (fixes mgba.io/i/1602)
- Qt: Fix sprite view using wrong base address (fixes mgba.io/i/1603) Misc: - GB Memory: Support manual SRAM editing (fixes mgba.io/i/1580) + - GBA I/O: Stop logging several harmless invalid register reads - Debugger: Separate aliases from main commands - Debugger: Print break-/watchpoint ID when breaking in CLI - SDL: Use controller GUID instead of name
M
src/gba/io.c
→
src/gba/io.c
@@ -826,8 +826,10 @@ case REG_DMA0CNT_LO:
case REG_DMA1CNT_LO: case REG_DMA2CNT_LO: case REG_DMA3CNT_LO: - // Write-only register - mLOG(GBA_IO, GAME_ERROR, "Read from write-only I/O register: %03X", address); + // Many, many things read from the DMA register + case REG_MAX: + // Some bad interrupt libraries will read from this + // (Silent) write-only register return 0; case REG_JOY_RECV_LO:@@ -900,8 +902,6 @@ case REG_WAITCNT:
case REG_IME: // Handled transparently by registers break; - case REG_MAX: - // Some bad interrupt libraries will read from this case 0x066: case 0x06E: case 0x076: