all repos — mgba @ 199f692d553187b92e2015f6e4eb29d21f11c1bc

mGBA Game Boy Advance Emulator

Qt: Remove unused variables

* The usage for this one was removed in
  be3e884ba51609b058b0da46c7e8bded3d2a7376
* This one is not used since afae3c8b807577123c93f32f1145422fc55500af
  which moved the whole refresh process into its own method
* I couldn't find any usage of this one in the history, it was probably
  never read.
* This one was used until 10d5588d4cc543f07b4f6bf21e8a3bac63fb02f3 which
  removed the usage but not the declaration
* Unused since cf7017dd867a542f3808f1e6287b683da92d0553
Bastien Orivel eijebong@bananium.fr
Wed, 28 Oct 2020 19:13:32 +0100
commit

199f692d553187b92e2015f6e4eb29d21f11c1bc

parent

b7999071434ad01e8566562f58aec172ff165847

5 files changed, 0 insertions(+), 6 deletions(-)

jump to
M src/platform/qt/GBAApp.cpp → src/platform/qt/GBAApp.cpp 
@@ -112,7 +112,6 @@ if (m_windows.count() >= MAX_GBAS) {
 		return nullptr;
 	}
 	Window* w = new Window(&m_manager, m_configController, m_multiplayer.attached());
-	int windowId = m_multiplayer.attached();
 	connect(w, &Window::destroyed, [this, w]() {
 		m_windows.removeAll(w);
 		for (Window* w : m_windows) {
M src/platform/qt/GBAKeyEditor.cpp → src/platform/qt/GBAKeyEditor.cpp 
@@ -36,7 +36,6 @@ {
 	setWindowFlags(windowFlags() & ~Qt::WindowFullscreenButtonHint);
 	setMinimumSize(300, 300);
 
-	const mInputMap* map = controller->map();
 	controller->stealFocus(this);
 
 	m_keyDU = new KeyEditor(this);
M src/platform/qt/InputController.cpp → src/platform/qt/InputController.cpp 
@@ -771,7 +771,6 @@ if (status != QCamera::LoadedStatus || m_camera->state() == QCamera::ActiveState) {
 		return;
 	}
 #if (QT_VERSION >= QT_VERSION_CHECK(5, 5, 0))
-	QVideoFrame::PixelFormat format(QVideoFrame::Format_RGB32);
 	QCameraViewfinderSettings settings;
 	QSize size(1280, 720);
 	auto cameraRes = m_camera->supportedViewfinderResolutions(settings);

@@ -791,7 +790,6 @@ bool goodFormatFound = false;
 	for (const auto& goodFormat : goodFormats) {
 		if (cameraFormats.contains(goodFormat)) {
 			settings.setPixelFormat(goodFormat);
-			format = goodFormat;
 			goodFormatFound = true;
 			break;
 		}
M src/platform/qt/MemoryModel.cpp → src/platform/qt/MemoryModel.cpp 
@@ -336,7 +336,6 @@ painter.setPen(palette.color(QPalette::WindowText));
 	static QChar c0('0');
 	static QString arg("%0");
 	static QString arg2("%0:%1");
-	QSizeF letterSize = QSizeF(m_letterWidth, m_cellHeight);
 	painter.drawStaticText(QPointF((m_margins.left() - m_regionName.size().width() - 1) / 2.0, 0), m_regionName);
 	painter.drawText(
 	    QRect(QPoint(viewport()->size().width() - m_margins.right(), 0), QSize(m_margins.right(), m_margins.top())),
M src/platform/qt/MemorySearch.cpp → src/platform/qt/MemorySearch.cpp 
@@ -40,7 +40,6 @@ params->memoryFlags = mCORE_MEMORY_WRITE;
 	if (m_ui.searchROM->isChecked()) {
 		params->memoryFlags |= mCORE_MEMORY_READ;
 	}
-	mCore* core = m_controller->thread()->core;
 
 	QByteArray string;
 	bool ok = false;