all repos — mgba @ 1d58985d2508fcfe91c6b485e8fe2c3f1ee64ad4

mGBA Game Boy Advance Emulator

GBA: Fix endianness issues in renderer proxy
Vicki Pfau vi@endrift.com
Fri, 14 Aug 2020 21:31:32 -0700
commit

1d58985d2508fcfe91c6b485e8fe2c3f1ee64ad4

parent

1ad033d9254795cac4c6db28e4bcab815e3dfb78

2 files changed, 3 insertions(+), 2 deletions(-)

jump to
M CHANGESCHANGES

@@ -11,6 +11,7 @@ - 3DS: Fix crash with libctru 2.0 when exiting

- Core: Fix reported ROM size when a fixed buffer size is used - Core: Fix memory leak loading ELF files - GBA: Disable more checks when loading GS save with checks disabled (fixes mgba.io/i/1851) + - GBA: Fix endianness issues in renderer proxy - GBA Core: Fix memory leak when loading symbols - Qt: Add dummy English translation file (fixes mgba.io/i/1469) - mGUI: Fix closing down a game if an exit is signalled
M src/gba/extra/proxy.csrc/gba/extra/proxy.c

@@ -178,13 +178,13 @@ proxyRenderer->backend->writeVideoRegister(proxyRenderer->backend, item->address, item->value);

break; case DIRTY_PALETTE: if (item->address < SIZE_PALETTE_RAM) { - logger->palette[item->address >> 1] = item->value; + STORE_16LE(item->value, item->address, logger->palette); proxyRenderer->backend->writePalette(proxyRenderer->backend, item->address, item->value); } break; case DIRTY_OAM: if (item->address < SIZE_OAM) { - logger->oam[item->address] = item->value; + STORE_16LE(item->value, item->address << 1, logger->oam); proxyRenderer->backend->writeOAM(proxyRenderer->backend, item->address); } break;