all repos — mgba @ 39740422598fba88e0b8598263432c30f339dc3f

mGBA Game Boy Advance Emulator

GBA Memory: Remove incorrect hack
Jeffrey Pfau jeffrey@endrift.com
Sun, 24 May 2015 22:50:21 -0700
commit

39740422598fba88e0b8598263432c30f339dc3f

parent

c8a58dbc3274d828fa1fc5eb5972392f9919c9cf

2 files changed, 0 insertions(+), 7 deletions(-)

jump to
M CHANGESCHANGES

@@ -22,7 +22,6 @@ - Finer control over FPS target

Bugfixes: - ARM7: Fix SWI and IRQ timings - GBA Audio: Force audio FIFOs to 32-bit - - GBA Memory: Ensure changing the timing of a DMA reschedules it - GBA Memory: Improve Thumb open bus behavior - VFS: Fix resource leaks if some allocations fail - Video: Fix an issue with very long filenames
M src/gba/memory.csrc/gba/memory.c

@@ -1313,12 +1313,6 @@ uint16_t GBAMemoryWriteDMACNT_HI(struct GBA* gba, int dma, uint16_t control) {

struct GBAMemory* memory = &gba->memory; struct GBADMA* currentDma = &memory->dma[dma]; int wasEnabled = GBADMARegisterIsEnable(currentDma->reg); - int oldTiming = GBADMARegisterGetTiming(currentDma->reg); - int newTiming = GBADMARegisterGetTiming(control); - // This is probably a huge hack...verify what this does on hardware - if (oldTiming && oldTiming != DMA_TIMING_CUSTOM && oldTiming != newTiming) { - wasEnabled = false; - } currentDma->reg = control; if (GBADMARegisterIsDRQ(currentDma->reg)) {