all repos — mgba @ 3a9ac188d40abee8689126bc0bf1a5b85054f625

mGBA Game Boy Advance Emulator

Debugger: Fix use-after-free in breakpoint clearing code (again)
Jeffrey Pfau jeffrey@endrift.com
Sat, 15 Aug 2015 22:12:26 -0700
commit

3a9ac188d40abee8689126bc0bf1a5b85054f625

parent

7a6582503fff4784d14250db3f3fa5592688bbee

2 files changed, 3 insertions(+), 0 deletions(-)

jump to
M CHANGESCHANGES

@@ -73,6 +73,7 @@ - Qt: Fix crashes on Windows by using using QMetaObject to do cross-thread calls

- GBA Video: Fix timing on first scanline - GBA: Ensure cycles never go negative - Util: Fix formatting of floats + - Debugger: Fix use-after-free in breakpoint clearing code Misc: - Qt: Handle saving input settings better - Debugger: Free watchpoints in addition to breakpoints
M src/debugger/debugger.csrc/debugger/debugger.c

@@ -155,6 +155,7 @@ next = &breakpoint->next;

if (breakpoint->address == address) { *previous = *next; free(breakpoint); + continue; } previous = next; }

@@ -179,6 +180,7 @@ next = &watchpoint->next;

if (watchpoint->address == address) { *previous = *next; free(watchpoint); + continue; } previous = next; }