Qt: Fix file handle leak on opening an invalid ROM
Vicki Pfau vi@endrift.com
Wed, 24 Jun 2020 02:41:17 -0700
2 files changed,
2 insertions(+),
0 deletions(-)
M
CHANGES
→
CHANGES
@@ -30,6 +30,7 @@ - GB Core: Fix extracting SRAM when none is present
- GBA Savedata: Fix extracting save when not yet configured in-game - Qt: Force OpenGL paint engine creation thread (fixes mgba.io/i/1642) - Qt: Fix static compilation in MinGW (fixes mgba.io/i/1769) + - Qt: Fix file handle leak on opening an invalid ROM Misc: - Debugger: Keep track of global cycle count - FFmpeg: Add looping option for GIF/APNG
M
src/platform/qt/CoreManager.cpp
→
src/platform/qt/CoreManager.cpp
@@ -83,6 +83,7 @@ }
mCore* core = mCoreFindVF(vf); if (!core) { + vf->close(vf); LOG(QT, ERROR) << tr("Could not load game. Are you sure it's in the correct format?"); return nullptr; }