all repos — mgba @ 4544177f8b16d0ce2123455260b08dc83c9f4b67

mGBA Game Boy Advance Emulator

Qt: Fix file handle leak on opening an invalid ROM
Vicki Pfau vi@endrift.com
Wed, 24 Jun 2020 02:41:17 -0700
commit

4544177f8b16d0ce2123455260b08dc83c9f4b67

parent

7003d817493a21de7f37ae548d9f7dcfd915f69f

2 files changed, 2 insertions(+), 0 deletions(-)

jump to
M CHANGESCHANGES

@@ -30,6 +30,7 @@ - GB Core: Fix extracting SRAM when none is present

- GBA Savedata: Fix extracting save when not yet configured in-game - Qt: Force OpenGL paint engine creation thread (fixes mgba.io/i/1642) - Qt: Fix static compilation in MinGW (fixes mgba.io/i/1769) + - Qt: Fix file handle leak on opening an invalid ROM Misc: - Debugger: Keep track of global cycle count - FFmpeg: Add looping option for GIF/APNG
M src/platform/qt/CoreManager.cppsrc/platform/qt/CoreManager.cpp

@@ -83,6 +83,7 @@ }

mCore* core = mCoreFindVF(vf); if (!core) { + vf->close(vf); LOG(QT, ERROR) << tr("Could not load game. Are you sure it's in the correct format?"); return nullptr; }