all repos — mgba @ 50d38dff620680b428392ac4d08cf5e582f09a53

mGBA Game Boy Advance Emulator

GBA Video: Don't draw sprites using unmapped VRAM in GL renderer (fixes #1865)
Vicki Pfau vi@endrift.com
Sat, 22 Aug 2020 21:56:57 -0700
commit

50d38dff620680b428392ac4d08cf5e582f09a53

parent

a1dfd69c062a1741d2e783b2c34fd49a863119a0

2 files changed, 5 insertions(+), 0 deletions(-)

jump to
M CHANGESCHANGES

@@ -7,6 +7,7 @@ - GBA Audio: Fix stereo in XQ audio

- GBA Audio: Fix volume/mute in XQ audio (fixes mgba.io/i/1864) - GBA Hardware: Fix GB Player detection on big endian platforms - GBA Video: Invalidate map cache when modifying BGCNT (fixes mgba.io/i/1846) + - GBA Video: Don't draw sprites using unmapped VRAM in GL renderer (fixes mgba.io/i/1865) Other fixes: - 3DS: Redo video sync to be more precise - 3DS: Fix crash with libctru 2.0 when exiting
M src/gba/renderers/gl.csrc/gba/renderers/gl.c

@@ -1647,6 +1647,10 @@ int height = GBAVideoObjSizes[GBAObjAttributesAGetShape(sprite->a) * 4 + GBAObjAttributesBGetSize(sprite->b)][1];

int32_t x = (uint32_t) GBAObjAttributesBGetX(sprite->b) << 23; x >>= 23; + if (GBARegisterDISPCNTGetMode(renderer->dispcnt) >= 3 && GBAObjAttributesCGetTile(sprite->c) < 512) { + return; + } + int align = GBAObjAttributesAIs256Color(sprite->a) && !GBARegisterDISPCNTIsObjCharacterMapping(renderer->dispcnt); unsigned charBase = (BASE_TILE >> 1) + (GBAObjAttributesCGetTile(sprite->c) & ~align) * 0x10; int stride = GBARegisterDISPCNTIsObjCharacterMapping(renderer->dispcnt) ? (width >> 3) : (0x20 >> GBAObjAttributesAGet256Color(sprite->a));