all repos — mgba @ 6aa5647fc4b3d45aaa138a1541e0cba582056a5a

mGBA Game Boy Advance Emulator

GBA DMA: Fix Display Start DMAs
Vicki Pfau vi@endrift.com
Fri, 22 Feb 2019 18:48:41 -0800
commit

6aa5647fc4b3d45aaa138a1541e0cba582056a5a

parent

407f5988aaead60853542c7ec3503f1dcba074fa

2 files changed, 2 insertions(+), 1 deletions(-)

jump to
M CHANGES → CHANGES 
@@ -19,6 +19,7 @@ - Qt: Fix color picking in sprite view (fixes mgba.io/i/1307)
  - GB: Fix crash when accessing SRAM if no save loaded and cartridge has no SRAM
  - Python: Fix crash when deleting files owned by library
  - Python: Make sure GB link object isn't GC'd before GB object
+ - GBA DMA: Fix Display Start DMAs
 Misc:
  - GBA Savedata: EEPROM performance fixes
  - GBA Savedata: Automatically map 1Mbit Flash files as 1Mbit Flash
M src/gba/dma.c → src/gba/dma.c 
@@ -182,7 +182,7 @@ } else {
 		dma->nextCount = 0;
 		bool noRepeat = !GBADMARegisterIsRepeat(dma->reg);
 		noRepeat |= GBADMARegisterGetTiming(dma->reg) == GBA_DMA_TIMING_NOW;
-		noRepeat |= memory->activeDMA == 3 && GBADMARegisterGetTiming(dma->reg) == GBA_DMA_TIMING_CUSTOM;
+		noRepeat |= memory->activeDMA == 3 && GBADMARegisterGetTiming(dma->reg) == GBA_DMA_TIMING_CUSTOM && gba->video.vcount == VIDEO_VERTICAL_PIXELS + 1;
 		if (noRepeat) {
 			dma->reg = GBADMARegisterClearEnable(dma->reg);