all repos — mgba @ 7b3900ff937341eafac2e2ef3f05a0e17e2c4e94

mGBA Game Boy Advance Emulator

Qt: Load/save bytes from memory viewer in the order visible (fixes #1900)
Vicki Pfau vi@endrift.com
Tue, 06 Oct 2020 01:11:34 -0700
commit

7b3900ff937341eafac2e2ef3f05a0e17e2c4e94

parent

22950a679673274f5b857d6c8570a7ac22c5120b

1 files changed, 4 insertions(+), 4 deletions(-)

jump to
M src/platform/qt/MemoryModel.cpp → src/platform/qt/MemoryModel.cpp 
@@ -246,7 +246,7 @@ case 2:
 		for (uint32_t i = m_selection.first; i < m_selection.second; i += m_align) {
 			quint16 datum = m_core->rawRead16(m_core, i, m_currentBank);
 			char leDatum[2];
-			STORE_16LE(datum, 0, (uint16_t*) leDatum);
+			STORE_16BE(datum, 0, (uint16_t*) leDatum);
 			bytes.append(leDatum, 2);
 		}
 		break;

@@ -254,7 +254,7 @@ case 4:
 		for (uint32_t i = m_selection.first; i < m_selection.second; i += m_align) {
 			quint32 datum = m_core->rawRead32(m_core, i, m_currentBank);
 			char leDatum[4];
-			STORE_32LE(datum, 0, (uint16_t*) leDatum);
+			STORE_32BE(datum, 0, (uint32_t*) leDatum);
 			bytes.append(leDatum, 4);
 		}
 		break;

@@ -275,7 +275,7 @@ case 2:
 		for (int i = 0; i < bytes.size(); i += m_align, addr += m_align) {
 			char leDatum[2]{ bytes[i], bytes[i + 1] };
 			uint16_t datum;
-			LOAD_16LE(datum, 0, leDatum);
+			LOAD_16BE(datum, 0, leDatum);
 			m_core->rawWrite16(m_core, addr, m_currentBank, datum);
 		}
 		break;

@@ -283,7 +283,7 @@ case 4:
 		for (int i = 0; i < bytes.size(); i += m_align, addr += m_align) {
 			char leDatum[4]{ bytes[i], bytes[i + 1], bytes[i + 2], bytes[i + 3] };
 			uint32_t datum;
-			LOAD_32LE(datum, 0, leDatum);
+			LOAD_32BE(datum, 0, leDatum);
 			m_core->rawWrite32(m_core, addr, m_currentBank, datum);
 		}
 		break;