all repos — mgba @ 8a7f8c67fce5b760320c0758662d7528cf979bd9

mGBA Game Boy Advance Emulator

GBA Video: Fix invalid read in mode 4 mosaic
Vicki Pfau vi@endrift.com
Sun, 28 Jun 2020 15:42:10 -0700
commit

8a7f8c67fce5b760320c0758662d7528cf979bd9

parent

b68c393223ed73d81f4c9896c3d6e0e7262243e3

2 files changed, 2 insertions(+), 1 deletions(-)

jump to
M CHANGES → CHANGES 
@@ -22,6 +22,7 @@ - GBA Memory: Improve gamepak prefetch timing
  - GBA SIO: Fix copying Normal mode transfer values
  - GBA Video: Latch scanline at end of Hblank (fixes mgba.io/i/1319)
  - GBA Video: Fix Hblank timing
+ - GBA Video: Fix invalid read in mode 4 mosaic
  - SM83: Emulate HALT bug
 Other fixes:
  - All: Improve export headers (fixes mgba.io/i/1738)
M src/gba/renderers/software-bg.c → src/gba/renderers/software-bg.c 
@@ -128,7 +128,7 @@
 void GBAVideoSoftwareRendererDrawBackgroundMode4(struct GBAVideoSoftwareRenderer* renderer, struct GBAVideoSoftwareBackground* background, int inY) {
 	BACKGROUND_BITMAP_INIT;
 
-	uint16_t color = renderer->normalPalette[0];
+	uint16_t color = 0;
 	uint32_t offset = 0;
 	if (GBARegisterDISPCNTIsFrameSelect(renderer->dispcnt)) {
 		offset = 0xA000;