all repos — mgba @ 8da1cdc63d0e13bad27b7224f8f33a023e0041b9

mGBA Game Boy Advance Emulator

Qt: Fix file handle leak on opening an invalid ROM
Vicki Pfau vi@endrift.com
Wed, 24 Jun 2020 02:41:17 -0700
commit

8da1cdc63d0e13bad27b7224f8f33a023e0041b9

parent

f6782850bd522d6778766b61c9e02abcd0e0abc4

2 files changed, 2 insertions(+), 0 deletions(-)

jump to
M CHANGESCHANGES

@@ -8,6 +8,7 @@ Other fixes:

- All: Correct format strings for some numbers on Windows (fixes mgba.io/i/1794) - GB Core: Fix extracting SRAM when none is present - GBA Savedata: Fix extracting save when not yet configured in-game + - Qt: Fix file handle leak on opening an invalid ROM Misc: - Qt: Add per-page scrolling to memory view (fixes mgba.io/i/1795) - Qt: Add setting to display ROM filename in title (closes mgba.io/i/1784)
M src/platform/qt/CoreManager.cppsrc/platform/qt/CoreManager.cpp

@@ -83,6 +83,7 @@ }

mCore* core = mCoreFindVF(vf); if (!core) { + vf->close(vf); LOG(QT, ERROR) << tr("Could not load game. Are you sure it's in the correct format?"); return nullptr; }