all repos — mgba @ 955251232918e504505997db2e4169ff29a35b36

mGBA Game Boy Advance Emulator

Util: Fix resource leak in UTF-8 handling code
Jeffrey Pfau jeffrey@endrift.com
Wed, 22 Apr 2015 22:02:55 -0700
commit

955251232918e504505997db2e4169ff29a35b36

parent

c4aedfa69aff7c8d26e5199b006196f47fe517c3

2 files changed, 3 insertions(+), 1 deletions(-)

jump to
M CHANGESCHANGES

@@ -35,6 +35,7 @@ - Qt: Fix multiplayer windows opening as the wrong size

- Qt: Fix controllers sometimes not loading the right profile - GBA: Fix hang when loading a savestate if sync to video is enabled - Debugger: Fix use-after-free in breakpoint clearing code + - Util: Fix resource leak in UTF-8 handling code Misc: - Qt: Show multiplayer numbers in window title - Qt: Handle saving input settings better
M src/util/string.csrc/util/string.c

@@ -178,13 +178,14 @@ memcpy(utf8, buffer, bytes);

offset = utf8 + bytes; } else if (utf8Length >= utf8TotalBytes) { char* newUTF8 = realloc(utf8, utf8TotalBytes * 2); + offset = offset - utf8 + newUTF8; if (newUTF8 != utf8) { free(utf8); } if (!newUTF8) { return 0; } - offset = offset - utf8 + newUTF8; + utf8 = newUTF8; memcpy(offset, buffer, bytes); offset += bytes; }