Qt: Begin mopping up warnings
Vicki Pfau vi@endrift.com
Sat, 01 Aug 2020 03:35:14 -0700
1 files changed,
22 insertions(+),
21 deletions(-)
jump to
M
src/platform/qt/Window.cpp
→
src/platform/qt/Window.cpp
@@ -582,7 +582,7 @@ }
event->accept(); } -void Window::resizeEvent(QResizeEvent* event) { +void Window::resizeEvent(QResizeEvent*) { if (!isFullScreen()) { m_config->setOption("height", m_screenWidget->height()); m_config->setOption("width", m_screenWidget->width());@@ -874,7 +874,8 @@ fail->setAttribute(Qt::WA_DeleteOnClose);
fail->show(); } -void Window::unimplementedBiosCall(int call) { +void Window::unimplementedBiosCall(int) { + // TODO: Mention which call? if (m_hitUnimplementedBiosCall) { return; }@@ -1126,7 +1127,7 @@
m_actions.addAction(tr("Load &patch..."), "loadPatch", this, &Window::selectPatch, "file"); #ifdef M_CORE_GBA - Action* bootBIOS = m_actions.addAction(tr("Boot BIOS"), "bootBIOS", [this]() { + m_actions.addAction(tr("Boot BIOS"), "bootBIOS", [this]() { setController(m_manager->loadBIOS(PLATFORM_GBA, m_config->getOption("gba.bios")), QString()); }, "file"); #endif@@ -1137,7 +1138,7 @@ Action* scanCard = addGameAction(tr("Scan e-Reader dotcodes..."), "scanCard", this, &Window::scanCard, "file");
m_platformActions.insert(PLATFORM_GBA, scanCard); #endif - Action* romInfo = addGameAction(tr("ROM &info..."), "romInfo", openControllerTView<ROMInfo>(), "file"); + addGameAction(tr("ROM &info..."), "romInfo", openControllerTView<ROMInfo>(), "file"); m_actions.addMenu(tr("Recent"), "mru", "file"); m_actions.addSeparator("file");@@ -1242,7 +1243,7 @@ addGameAction(tr("Sh&utdown"), "shutdown", [this]() {
m_controller->stop(); }, "emu"); - Action* yank = addGameAction(tr("Yank game pak"), "yank", [this]() { + addGameAction(tr("Yank game pak"), "yank", [this]() { m_controller->yankPak(); }, "emu");@@ -1275,7 +1276,7 @@ }, "emu", QKeySequence("Shift+Tab"));
m_actions.addMenu(tr("Fast forward speed"), "fastForwardSpeed", "emu"); ConfigOption* ffspeed = m_config->addOption("fastForwardRatio"); - ffspeed->connect([this](const QVariant& value) { + ffspeed->connect([this](const QVariant&) { reloadConfig(); }, this); ffspeed->addValue(tr("Unbounded"), -1.0f, &m_actions, "fastForwardSpeed");@@ -1305,14 +1306,14 @@ m_nonMpActions.append(frameRewind);
ConfigOption* videoSync = m_config->addOption("videoSync"); videoSync->addBoolean(tr("Sync to &video"), &m_actions, "emu"); - videoSync->connect([this](const QVariant& value) { + videoSync->connect([this](const QVariant&) { reloadConfig(); }, this); m_config->updateOption("videoSync"); ConfigOption* audioSync = m_config->addOption("audioSync"); audioSync->addBoolean(tr("Sync to &audio"), &m_actions, "emu"); - audioSync->connect([this](const QVariant& value) { + audioSync->connect([this](const QVariant&) { reloadConfig(); }, this); m_config->updateOption("audioSync");@@ -1425,7 +1426,7 @@ m_config->updateOption("resampleVideo");
m_actions.addMenu(tr("Frame&skip"),"skip", "av"); ConfigOption* skip = m_config->addOption("frameskip"); - skip->connect([this](const QVariant& value) { + skip->connect([this](const QVariant&) { reloadConfig(); }, this); for (int i = 0; i <= 10; ++i) {@@ -1564,62 +1565,62 @@ m_controller->endVideoLog();
}, "tools"); ConfigOption* skipBios = m_config->addOption("skipBios"); - skipBios->connect([this](const QVariant& value) { + skipBios->connect([this](const QVariant&) { reloadConfig(); }, this); ConfigOption* useBios = m_config->addOption("useBios"); - useBios->connect([this](const QVariant& value) { + useBios->connect([this](const QVariant&) { reloadConfig(); }, this); ConfigOption* buffers = m_config->addOption("audioBuffers"); - buffers->connect([this](const QVariant& value) { + buffers->connect([this](const QVariant&) { reloadConfig(); }, this); ConfigOption* sampleRate = m_config->addOption("sampleRate"); - sampleRate->connect([this](const QVariant& value) { + sampleRate->connect([this](const QVariant&) { reloadConfig(); }, this); ConfigOption* volume = m_config->addOption("volume"); - volume->connect([this](const QVariant& value) { + volume->connect([this](const QVariant&) { reloadConfig(); }, this); ConfigOption* volumeFf = m_config->addOption("fastForwardVolume"); - volumeFf->connect([this](const QVariant& value) { + volumeFf->connect([this](const QVariant&) { reloadConfig(); }, this); ConfigOption* muteFf = m_config->addOption("fastForwardMute"); - muteFf->connect([this](const QVariant& value) { + muteFf->connect([this](const QVariant&) { reloadConfig(); }, this); ConfigOption* rewindEnable = m_config->addOption("rewindEnable"); - rewindEnable->connect([this](const QVariant& value) { + rewindEnable->connect([this](const QVariant&) { reloadConfig(); }, this); ConfigOption* rewindBufferCapacity = m_config->addOption("rewindBufferCapacity"); - rewindBufferCapacity->connect([this](const QVariant& value) { + rewindBufferCapacity->connect([this](const QVariant&) { reloadConfig(); }, this); ConfigOption* allowOpposingDirections = m_config->addOption("allowOpposingDirections"); - allowOpposingDirections->connect([this](const QVariant& value) { + allowOpposingDirections->connect([this](const QVariant&) { reloadConfig(); }, this); ConfigOption* saveStateExtdata = m_config->addOption("saveStateExtdata"); - saveStateExtdata->connect([this](const QVariant& value) { + saveStateExtdata->connect([this](const QVariant&) { reloadConfig(); }, this); ConfigOption* loadStateExtdata = m_config->addOption("loadStateExtdata"); - loadStateExtdata->connect([this](const QVariant& value) { + loadStateExtdata->connect([this](const QVariant&) { reloadConfig(); }, this);