all repos — mgba @ b1a06ed52bd8f9db00dcd722198deedd8a184f69

mGBA Game Boy Advance Emulator

Cheats: Fix indirect write cheats (fixes #2026)
Vicki Pfau vi@endrift.com
Wed, 27 Jan 2021 20:24:26 -0800
commit

b1a06ed52bd8f9db00dcd722198deedd8a184f69

parent

6154ed91cb48a8ad25b9986ea03553f1e27351c1

2 files changed, 2 insertions(+), 1 deletions(-)

jump to
M CHANGESCHANGES

@@ -58,6 +58,7 @@ - SM83: Emulate HALT bug

Other fixes: - 3DS: Fix thread cleanup - All: Improve export headers (fixes mgba.io/i/1738) + - Cheats: Fix indirect write cheats (fixes mgba.io/i/2026) - CMake: Fix build with downstream minizip that exports incompatible symbols - CMake: Link with correct OpenGL library (fixes mgba.io/i/1872) - Core: Ensure ELF regions can be written before trying
M src/core/cheats.csrc/core/cheats.c

@@ -666,7 +666,7 @@ performAssignment = true;

break; case CHEAT_ASSIGN_INDIRECT: value = operand; - address = _readMem(device->p, address + cheat->addressOffset, 4); + address = _readMem(device->p, address, 4) + cheat->addressOffset; performAssignment = true; break; case CHEAT_AND: