all repos — mgba @ b49f072c94ac6537ee9c2d86370d1f6611612194

mGBA Game Boy Advance Emulator

Qt: Fix "restart needed" dialog after first config (fixes #1601)
Vicki Pfau vi@endrift.com
Fri, 20 Dec 2019 21:10:29 -0800
commit

b49f072c94ac6537ee9c2d86370d1f6611612194

parent

f9b1c960cb42f148512d77ef94e754245fd6af8a

2 files changed, 6 insertions(+), 2 deletions(-)

jump to
M CHANGESCHANGES

@@ -102,6 +102,7 @@ - Qt: Fix fast forward mute being reset (fixes mgba.io/i/1574)

- Qt: Fix scrollbar arrows in memory view (fixes mgba.io/i/1558) - Qt: Fix several cases where shader selections don't get saved - Qt: Fix division by zero error in invalid TilePainter state + - Qt: Fix "restart needed" dialog after first config (fixes mgba.io/i/1601) Misc: - GB Memory: Support manual SRAM editing (fixes mgba.io/i/1580) - SDL: Use controller GUID instead of name
M src/platform/qt/SettingsView.cppsrc/platform/qt/SettingsView.cpp

@@ -472,9 +472,12 @@ emit displayDriverChanged();

} QVariant cameraDriver = m_ui.cameraDriver->itemData(m_ui.cameraDriver->currentIndex()); - if (cameraDriver != m_controller->getQtOption("cameraDriver")) { + QVariant oldCameraDriver = m_controller->getQtOption("cameraDriver"); + if (cameraDriver != oldCameraDriver) { m_controller->setQtOption("cameraDriver", cameraDriver); - emit cameraDriverChanged(); + if (cameraDriver.toInt() != static_cast<int>(InputController::CameraDriver::NONE) || !oldCameraDriver.isNull()) { + emit cameraDriverChanged(); + } } QVariant camera = m_ui.camera->itemData(m_ui.camera->currentIndex());