all repos — mgba @ bab8ce180581bc9d1e4584a5d2b8d86efddf219e

mGBA Game Boy Advance Emulator

GB Serialize: Fix loading states with negative pixel x (fixes #1293)
Vicki Pfau vi@endrift.com
Tue, 12 Feb 2019 09:20:37 -0800
commit

bab8ce180581bc9d1e4584a5d2b8d86efddf219e

parent

89c4214988ab9edd879eb0b4cb0f03ee12858e10

2 files changed, 2 insertions(+), 1 deletions(-)

jump to
M CHANGES → CHANGES 
@@ -4,6 +4,7 @@ - Switch: Fix final cleanup (fixes mgba.io/i/1283)
  - Qt: Fix tile and sprite views not always displaying at first
  - GBA Memory: Fix a few AGBPrint crashes
  - GBA Memory: Fix OOB ROM reads showing up as AGBPrint memory
+ - GB Serialize: Fix loading states with negative pixel x (fixes mgba.io/i/1293)
 Misc:
  - GBA Video: Improve sprite cycle counting (fixes mgba.io/i/1274)
M src/gb/serialize.c → src/gb/serialize.c 
@@ -113,7 +113,7 @@ mLOG(GB_STATE, WARN, "Savestate is corrupted: CPU cycles are too high");
 		error = true;
 	}
 	LOAD_16LE(check16, 0, &state->video.x);
-	if (check16 < 0 || check16 > GB_VIDEO_HORIZONTAL_PIXELS) {
+	if (check16 < -7 || check16 > GB_VIDEO_HORIZONTAL_PIXELS) {
 		mLOG(GB_STATE, WARN, "Savestate is corrupted: video x is out of range");
 		error = true;
 	}