all repos — mgba @ bb71c72bf8a3324716febc2c4a7515c5f655c59d

mGBA Game Boy Advance Emulator

Qt: std::move cleanup
Vicki Pfau vi@endrift.com
Mon, 22 Feb 2021 18:13:07 -0800
commit

bb71c72bf8a3324716febc2c4a7515c5f655c59d

parent

8926aeea011e2700d8b7fe3564840c571c091e8e

2 files changed, 3 insertions(+), 3 deletions(-)

jump to
M src/platform/qt/DisplayQt.cppsrc/platform/qt/DisplayQt.cpp

@@ -25,8 +25,8 @@ void DisplayQt::startDrawing(std::shared_ptr<CoreController> controller) {

QSize size = controller->screenDimensions(); m_width = size.width(); m_height = size.height(); - m_backing = std::move(QImage()); - m_oldBacking = std::move(QImage()); + m_backing = QImage(); + m_oldBacking = QImage(); m_isDrawing = true; m_context = controller; emit drawingStarted();
M src/platform/qt/ObjView.cppsrc/platform/qt/ObjView.cpp

@@ -271,7 +271,7 @@ }

QListWidgetItem* item = m_objs[i]; ObjInfo info; lookupObj(i, &info); - item->setIcon(QPixmap::fromImage(std::move(compositeObj(info)))); + item->setIcon(QPixmap::fromImage(compositeObj(info))); } }