M src/gb/audio.c → src/gb/audio.c

@@ -936,7 +936,7 @@ cycles *= 8 * audio->timingFactor;
 
 	uint32_t last = 0;
 	uint32_t now = cycles;
-	uint32_t next = cycles - cyclesLate;
+	int32_t next = cycles - cyclesLate;
 
 	if (audio->style == GB_AUDIO_GBA) {
 		last = ch->lastEvent;

M src/gb/core.c → src/gb/core.c

@@ -508,7 +508,7 @@ bios->close(bios);
 				bios = NULL;
 			}
 		}
-		if (bios) {
+		if (found && bios) {
 			GBLoadBIOS(gb, bios);
 		}
 	}

M src/gb/video.c → src/gb/video.c

@@ -187,7 +187,7 @@ renderer->vram = video->vram;
 	video->renderer->init(video->renderer, video->p->model, video->sgbBorders);
 }
 
-static bool _statIRQAsserted(struct GBVideo* video, GBRegisterSTAT stat) {
+static bool _statIRQAsserted(GBRegisterSTAT stat) {
 	// TODO: variable for the IRQ line value?
 	if (GBRegisterSTATIsLYCIRQ(stat) && GBRegisterSTATIsLYC(stat)) {
 		return true;
@@ -236,20 +236,20 @@
 		mTimingDeschedule(&video->p->timing, &video->frameEvent);
 		mTimingSchedule(&video->p->timing, &video->frameEvent, -cyclesLate);
 
-		if (!_statIRQAsserted(video, oldStat) && GBRegisterSTATIsOAMIRQ(video->stat)) {
+		if (!_statIRQAsserted(oldStat) && GBRegisterSTATIsOAMIRQ(video->stat)) {
 			video->p->memory.io[REG_IF] |= (1 << GB_IRQ_LCDSTAT);
 		}
 		video->p->memory.io[REG_IF] |= (1 << GB_IRQ_VBLANK);
 	}
 	video->stat = GBRegisterSTATSetMode(video->stat, video->mode);
-	if (!_statIRQAsserted(video, oldStat) && _statIRQAsserted(video, video->stat)) {
+	if (!_statIRQAsserted(oldStat) && _statIRQAsserted(video->stat)) {
 		video->p->memory.io[REG_IF] |= (1 << GB_IRQ_LCDSTAT);
 	}
 
 	// LYC stat is delayed 1 T-cycle
 	oldStat = video->stat;
 	video->stat = GBRegisterSTATSetLYC(video->stat, lyc == video->ly);
-	if (!_statIRQAsserted(video, oldStat) && _statIRQAsserted(video, video->stat)) {
+	if (!_statIRQAsserted(oldStat) && _statIRQAsserted(video->stat)) {
 		video->p->memory.io[REG_IF] |= (1 << GB_IRQ_LCDSTAT);
 	}
 
@@ -287,7 +287,7 @@
 	GBRegisterSTAT oldStat = video->stat;
 	video->stat = GBRegisterSTATSetMode(video->stat, video->mode);
 	video->stat = GBRegisterSTATSetLYC(video->stat, lyc == video->p->memory.io[REG_LY]);
-	if (!_statIRQAsserted(video, oldStat) && _statIRQAsserted(video, video->stat)) {
+	if (!_statIRQAsserted(oldStat) && _statIRQAsserted(video->stat)) {
 		video->p->memory.io[REG_IF] |= (1 << GB_IRQ_LCDSTAT);
 		GBUpdateIRQs(video->p);
 	}
@@ -305,7 +305,7 @@ video->mode = 3;
 	video->modeEvent.callback = _endMode3;
 	GBRegisterSTAT oldStat = video->stat;
 	video->stat = GBRegisterSTATSetMode(video->stat, video->mode);
-	if (!_statIRQAsserted(video, oldStat) && _statIRQAsserted(video, video->stat)) {
+	if (!_statIRQAsserted(oldStat) && _statIRQAsserted(video->stat)) {
 		video->p->memory.io[REG_IF] |= (1 << GB_IRQ_LCDSTAT);
 		GBUpdateIRQs(video->p);
 	}
@@ -326,7 +326,7 @@ video->mode = 0;
 	video->modeEvent.callback = _endMode0;
 	GBRegisterSTAT oldStat = video->stat;
 	video->stat = GBRegisterSTATSetMode(video->stat, video->mode);
-	if (!_statIRQAsserted(video, oldStat) && _statIRQAsserted(video, video->stat)) {
+	if (!_statIRQAsserted(oldStat) && _statIRQAsserted(video->stat)) {
 		video->p->memory.io[REG_IF] |= (1 << GB_IRQ_LCDSTAT);
 		GBUpdateIRQs(video->p);
 	}
@@ -416,7 +416,7 @@ video->p->memory.io[REG_LY] = 0;
 		GBRegisterSTAT oldStat = video->stat;
 		video->stat = GBRegisterSTATSetMode(video->stat, 0);
 		video->stat = GBRegisterSTATSetLYC(video->stat, video->ly == video->p->memory.io[REG_LYC]);
-		if (!_statIRQAsserted(video, oldStat) && _statIRQAsserted(video, video->stat)) {
+		if (!_statIRQAsserted(oldStat) && _statIRQAsserted(video->stat)) {
 			video->p->memory.io[REG_IF] |= (1 << GB_IRQ_LCDSTAT);
 			GBUpdateIRQs(video->p);
 		}
@@ -447,7 +447,7 @@ video->stat = (video->stat & 0x7) | (value & 0x78);
 	if (!GBRegisterLCDCIsEnable(video->p->memory.io[REG_LCDC]) || video->p->model >= GB_MODEL_CGB) {
 		return;
 	}
-	if (!_statIRQAsserted(video, oldStat) && video->mode < 3) {
+	if (!_statIRQAsserted(oldStat) && video->mode < 3) {
 		// TODO: variable for the IRQ line value?
 		video->p->memory.io[REG_IF] |= (1 << GB_IRQ_LCDSTAT);
 		GBUpdateIRQs(video->p);
@@ -458,7 +458,7 @@ void GBVideoWriteLYC(struct GBVideo* video, uint8_t value) {
 	GBRegisterSTAT oldStat = video->stat;
 	if (GBRegisterLCDCIsEnable(video->p->memory.io[REG_LCDC])) {
 		video->stat = GBRegisterSTATSetLYC(video->stat, value == video->ly);
-		if (!_statIRQAsserted(video, oldStat) && _statIRQAsserted(video, video->stat)) {
+		if (!_statIRQAsserted(oldStat) && _statIRQAsserted(video->stat)) {
 			video->p->memory.io[REG_IF] |= (1 << GB_IRQ_LCDSTAT);
 			GBUpdateIRQs(video->p);
 		}