all repos — mgba @ d588aa47e6567f74674d0fd4be7e31646661dee0

mGBA Game Boy Advance Emulator

GBA Hardware: Don't gate GBP features on not having an SIO driver installed
Vicki Pfau vi@endrift.com
Wed, 14 Oct 2020 23:15:35 -0700
commit

d588aa47e6567f74674d0fd4be7e31646661dee0

parent

73c8a343a5c350f5693fc8c9d0cf34102b9dcec4

1 files changed, 2 insertions(+), 1 deletions(-)

jump to
M src/gba/hardware.csrc/gba/hardware.c

@@ -546,13 +546,14 @@ }

gba->memory.hw.gbpTxPosition = 0; return; } - if (gba->keyCallback || gba->sio.drivers.normal) { + if (gba->keyCallback) { return; } if (GBAHardwarePlayerCheckScreen(&gba->video)) { gba->memory.hw.devices |= HW_GB_PLAYER; gba->memory.hw.gbpInputsPosted = 0; gba->keyCallback = &gba->memory.hw.gbpCallback.d; + // TODO: Check if the SIO driver is actually used first GBASIOSetDriver(&gba->sio, &gba->memory.hw.gbpDriver.d, SIO_NORMAL_32); } }