all repos — mgba @ daac1985c1ad0992ce3f60355ac117a24c01a9ce

mGBA Game Boy Advance Emulator

Qt: Show a warning when save file can't be opened
Vicki Pfau vi@endrift.com
Sun, 07 Jun 2020 15:52:26 -0700
commit

daac1985c1ad0992ce3f60355ac117a24c01a9ce

parent

33a675c07e46fff0cf74c45271e4b2d702b79aa0

3 files changed, 5 insertions(+), 2 deletions(-)

jump to
M CHANGESCHANGES

@@ -28,6 +28,7 @@ - GBA Serialize: Only flunk BIOS check if official BIOS was expected

- Qt: Disable Replace ROM option when no game loaded - Qt: Defer texture updates until frame is drawn (fixes mgba.io/i/1590) - Qt: Set icon for Discord Rich Presence + - Qt: Show a warning when save file can't be opened 0.8.1: (2020-02-16) Emulation fixes:
M src/gba/gba.csrc/gba/gba.c

@@ -433,7 +433,7 @@ }

bool GBALoadSave(struct GBA* gba, struct VFile* sav) { GBASavedataInit(&gba->memory.savedata, sav); - return true; + return sav; } void GBAYankROM(struct GBA* gba) {
M src/platform/qt/CoreManager.cppsrc/platform/qt/CoreManager.cpp

@@ -109,7 +109,9 @@ info = QFileInfo(base + "/" + path);

} bytes = info.dir().canonicalPath().toUtf8(); mDirectorySetAttachBase(&core->dirs, VDirOpen(bytes.constData())); - mCoreAutoloadSave(core); + if (!mCoreAutoloadSave(core)) { + LOG(QT, ERROR) << tr("Failed to open save file. Is the save directory writable?"); + } mCoreAutoloadCheats(core); CoreController* cc = new CoreController(core);