all repos — mgba @ dbd3aba5272012e16d66d6bc80a7cd653b8c8dbe

mGBA Game Boy Advance Emulator

Core: Fix crash modifying hash table entry (fixes #1673)
Vicki Pfau vi@endrift.com
Mon, 17 Feb 2020 17:55:29 -0800
commit

dbd3aba5272012e16d66d6bc80a7cd653b8c8dbe

parent

5f3dc723f613a3057c91751b36871fb237fb79fd

2 files changed, 4 insertions(+), 1 deletions(-)

jump to
M CHANGESCHANGES

@@ -1,6 +1,7 @@

0.8.2: (Future) Other fixes: - Core: Fix ELF loading regression (fixes mgba.io/i/1669) + - Core: Fix crash modifying hash table entry (fixes mgba.io/i/1673) 0.8.1: (2020-02-16) Emulation fixes:
M src/util/table.csrc/util/table.c

@@ -187,7 +187,9 @@ uint32_t hash = hash32(key, strlen(key), 0);

struct TableList* list; TABLE_LOOKUP_START(HASH_TABLE_COMPARATOR, list, hash) { if (value != lookupResult->value) { - table->deinitializer(lookupResult->value); + if (table->deinitializer) { + table->deinitializer(lookupResult->value); + } lookupResult->value = value; } return;