all repos — mgba @ f33a970304f0fb9e2ee852b3973bf07d8d45f441

mGBA Game Boy Advance Emulator

Qt: Fix FPS target maxing out at 59.727 (fixes #1421)
Vicki Pfau vi@endrift.com
Sun, 26 May 2019 21:37:18 -0700
commit

f33a970304f0fb9e2ee852b3973bf07d8d45f441

parent

5d05e38d27ccf8ec38865e04d2183735c49f9c9f

2 files changed, 2 insertions(+), 1 deletions(-)

jump to
M CHANGES → CHANGES 
@@ -21,6 +21,7 @@ Other fixes:
  - Qt: Fix some Qt display driver race conditions
  - Core: Improved lockstep driver reliability (Le Hoang Quyen)
  - Switch: Fix threading-related crash on second launch
+ - Qt: Fix FPS target maxing out at 59.727 (fixes mgba.io/i/1421)
 Misc:
  - GBA Savedata: EEPROM performance fixes
  - GBA Savedata: Automatically map 1Mbit Flash files as 1Mbit Flash
M src/platform/qt/SettingsView.cpp → src/platform/qt/SettingsView.cpp 
@@ -413,7 +413,7 @@ saveSetting("fastForwardRatio", m_ui.fastForwardRatio);
 	}
 
 	double nativeFps = double(GBA_ARM7TDMI_FREQUENCY) / double(VIDEO_TOTAL_LENGTH);
-	if (nativeFps - m_ui.fpsTarget->value() < 0.0001) {
+	if (fabs(nativeFps - m_ui.fpsTarget->value()) < 0.0001) {
 		m_controller->setOption("fpsTarget", QVariant(nativeFps));
 	} else {
 		saveSetting("fpsTarget", m_ui.fpsTarget);