M CHANGES → CHANGES

@@ -67,6 +67,7 @@ - GBA: SIO logging layer
  - Qt: Add application icon and XDG desktop files
  - GBA Thread: Split GBASync into a separate file
  - SDL: Properly check for initialization
+ - SDL: Clean up initialization functions
 
 0.2.1: (2015-05-13)
 Bugfixes:

M src/platform/sdl/sdl-audio.c → src/platform/sdl/sdl-audio.c

@@ -18,7 +18,7 @@ static void _GBASDLAudioCallback(void* context, Uint8* data, int len);
 
 bool GBASDLInitAudio(struct GBASDLAudio* context, struct GBAThread* threadContext) {
 	if (SDL_InitSubSystem(SDL_INIT_AUDIO) < 0) {
-		GBALog(0, GBA_LOG_ERROR, "Could not initialize SDL sound system");
+		GBALog(0, GBA_LOG_ERROR, "Could not initialize SDL sound system: %s", SDL_GetError());
 		return false;
 	}
 

M src/platform/sdl/sdl-events.c → src/platform/sdl/sdl-events.c

@@ -33,18 +33,22 @@ static int32_t _GBASDLReadGyroZ(struct GBARotationSource* rumble);
 static void _GBASDLRotationSample(struct GBARotationSource* source);
 
 bool GBASDLInitEvents(struct GBASDLEvents* context) {
-	int subsystem = SDL_INIT_JOYSTICK;
-#if SDL_VERSION_ATLEAST(2, 0, 0)
-	subsystem |= SDL_INIT_HAPTIC | SDL_INIT_VIDEO;
-
-	SDL_SetHint(SDL_HINT_JOYSTICK_ALLOW_BACKGROUND_EVENTS, "1");
-#endif
 #if SDL_VERSION_ATLEAST(2, 0, 4)
 	SDL_SetHint(SDL_HINT_NO_SIGNAL_HANDLERS, "1");
 #endif
-	if (SDL_InitSubSystem(subsystem) < 0) {
-		return false;
+	if (SDL_InitSubSystem(SDL_INIT_JOYSTICK) < 0) {
+		GBALog(0, GBA_LOG_ERROR, "SDL joystick initialization failed: %s", SDL_GetError());
 	}
+
+#if SDL_VERSION_ATLEAST(2, 0, 0)
+	SDL_SetHint(SDL_HINT_JOYSTICK_ALLOW_BACKGROUND_EVENTS, "1");
+	if (SDL_InitSubSystem(SDL_INIT_HAPTIC) < 0) {
+		GBALog(0, GBA_LOG_ERROR, "SDL haptic initialization failed: %s", SDL_GetError());
+	}
+	if (SDL_InitSubSystem(SDL_INIT_VIDEO) < 0) {
+		GBALog(0, GBA_LOG_ERROR, "SDL video initialization failed: %s", SDL_GetError());
+	}
+#endif
 
 	SDL_JoystickEventState(SDL_ENABLE);
 	int nJoysticks = SDL_NumJoysticks();
@@ -158,6 +162,10 @@ bool GBASDLAttachPlayer(struct GBASDLEvents* events, struct GBASDLPlayer* player) {
 	player->joystick = 0;
 	player->joystickIndex = SIZE_MAX;
 
+	if (events->playersAttached >= MAX_PLAYERS) {
+		return false;
+	}
+
 #if SDL_VERSION_ATLEAST(2, 0, 0)
 	player->rumble.d.setRumble = _GBASDLSetRumble;
 	CircleBufferInit(&player->rumble.history, RUMBLE_PWM);
@@ -177,10 +185,6 @@ player->rotation.gyroY = 1;
 	player->rotation.zDelta = 0;
 	CircleBufferInit(&player->rotation.zHistory, sizeof(float) * GYRO_STEPS);
 	player->rotation.p = player;
-
-	if (events->playersAttached >= MAX_PLAYERS) {
-		return false;
-	}
 
 	player->playerId = events->playersAttached;
 	size_t firstUnclaimed = SIZE_MAX;