all repos — mgba @ f99bdc07de7ce72e823d6fd6a1863bbc1adb556d

mGBA Game Boy Advance Emulator

GB Audio: Fix channel 4 initial LFSR
Vicki Pfau vi@endrift.com
Fri, 21 Sep 2018 14:15:27 -0700
commit

f99bdc07de7ce72e823d6fd6a1863bbc1adb556d

parent

97032109381c9029df57478fe2c3e4b8dcabe8cc

2 files changed, 3 insertions(+), 2 deletions(-)

jump to
M CHANGES → CHANGES 
@@ -59,6 +59,7 @@ - FFmpeg: Fix encoding audio/video queue issues
  - GB Serialize: Fix IRQ pending/EI pending confusion
  - GB MBC: Improve multicart detection heuristic (fixes mgba.io/i/1177)
  - GB Audio: Fix channel 3 reset value
+ - GB Audio: Fix channel 4 initial LFSR
 Misc:
  - GBA Timer: Use global cycles for timers
  - GBA: Extend oddly-sized ROMs to full address space (fixes mgba.io/i/722)
M src/gb/audio.c → src/gb/audio.c 
@@ -377,9 +377,9 @@ if (GBAudioRegisterNoiseControlIsRestart(value)) {
 		audio->playingCh4 = _resetEnvelope(&audio->ch4.envelope);
 
 		if (audio->ch4.power) {
-			audio->ch4.lfsr = 0x40;
+			audio->ch4.lfsr = 0x7F;
 		} else {
-			audio->ch4.lfsr = 0x4000;
+			audio->ch4.lfsr = 0x7FFF;
 		}
 		if (!audio->ch4.length) {
 			audio->ch4.length = 64;