all repos — mgba @ 1733c6456125b0a49c7f7fcac28ffe4328ce4701

mGBA Game Boy Advance Emulator

Qt: Customizable autofire speed (closes #789)
Vicki Pfau vi@endrift.com
Thu, 03 Aug 2017 22:43:15 -0700
commit

1733c6456125b0a49c7f7fcac28ffe4328ce4701

parent

7bd29d6e44c60a7812c499879e160d3a95e53f25

3 files changed, 40 insertions(+), 20 deletions(-)

jump to
M CHANGESCHANGES

@@ -5,6 +5,7 @@ - Game Boy Camera support

- Qt: Set default Game Boy colors - Game Boy Printer support - Super Game Boy support + - Customizable autofire speed Bugfixes: - GB Audio: Make audio unsigned with bias (fixes mgba.io/i/749) - Python: Fix importing .gb or .gba before .core
M src/platform/qt/SettingsView.cppsrc/platform/qt/SettingsView.cpp

@@ -288,6 +288,7 @@ saveSetting("videoSync", m_ui.videoSync);

saveSetting("audioSync", m_ui.audioSync); saveSetting("frameskip", m_ui.frameskip); saveSetting("fpsTarget", m_ui.fpsTarget); + saveSetting("autofireThreshold", m_ui.autofireThreshold); saveSetting("lockAspectRatio", m_ui.lockAspectRatio); saveSetting("lockIntegerScaling", m_ui.lockIntegerScaling); saveSetting("volume", m_ui.volume);

@@ -391,6 +392,7 @@ loadSetting("videoSync", m_ui.videoSync);

loadSetting("audioSync", m_ui.audioSync); loadSetting("frameskip", m_ui.frameskip); loadSetting("fpsTarget", m_ui.fpsTarget); + loadSetting("autofireThreshold", m_ui.autofireThreshold); loadSetting("lockAspectRatio", m_ui.lockAspectRatio); loadSetting("lockIntegerScaling", m_ui.lockIntegerScaling); loadSetting("volume", m_ui.volume);
M src/platform/qt/SettingsView.uisrc/platform/qt/SettingsView.ui

@@ -7,7 +7,7 @@ <rect>

<x>0</x> <y>0</y> <width>650</width> - <height>454</height> + <height>488</height> </rect> </property> <property name="sizePolicy">

@@ -545,28 +545,28 @@ </widget>

</item> </layout> </item> - <item row="1" column="0" colspan="2"> + <item row="2" column="0" colspan="2"> <widget class="Line" name="line"> <property name="orientation"> <enum>Qt::Horizontal</enum> </property> </widget> </item> - <item row="2" column="1"> + <item row="3" column="1"> <widget class="QCheckBox" name="rewind"> <property name="text"> <string>Enable rewind</string> </property> </widget> </item> - <item row="3" column="0"> + <item row="4" column="0"> <widget class="QLabel" name="label_8"> <property name="text"> <string>Rewind history:</string> </property> </widget> </item> - <item row="3" column="1"> + <item row="4" column="1"> <layout class="QHBoxLayout" name="horizontalLayout_13"> <item> <widget class="QSpinBox" name="rewindCapacity">

@@ -584,21 +584,21 @@ </widget>

</item> </layout> </item> - <item row="5" column="0" colspan="2"> + <item row="6" column="0" colspan="2"> <widget class="Line" name="line_3"> <property name="orientation"> <enum>Qt::Horizontal</enum> </property> </widget> </item> - <item row="6" column="0"> + <item row="7" column="0"> <widget class="QLabel" name="label_15"> <property name="text"> <string>Idle loops:</string> </property> </widget> </item> - <item row="6" column="1"> + <item row="7" column="1"> <widget class="QComboBox" name="idleOptimization"> <item> <property name="text">

@@ -617,21 +617,21 @@ </property>

</item> </widget> </item> - <item row="8" column="0" colspan="2"> + <item row="9" column="0" colspan="2"> <widget class="Line" name="line_2"> <property name="orientation"> <enum>Qt::Horizontal</enum> </property> </widget> </item> - <item row="9" column="0"> + <item row="10" column="0"> <widget class="QLabel" name="label_24"> <property name="text"> <string>Savestate extra data:</string> </property> </widget> </item> - <item row="9" column="1"> + <item row="10" column="1"> <widget class="QCheckBox" name="saveStateScreenshot"> <property name="text"> <string>Screenshot</string>

@@ -641,7 +641,7 @@ <bool>true</bool>

</property> </widget> </item> - <item row="10" column="1"> + <item row="11" column="1"> <widget class="QCheckBox" name="saveStateSave"> <property name="text"> <string>Save data</string>

@@ -651,7 +651,7 @@ <bool>true</bool>

</property> </widget> </item> - <item row="11" column="1"> + <item row="12" column="1"> <widget class="QCheckBox" name="saveStateCheats"> <property name="text"> <string>Cheat codes</string>

@@ -661,14 +661,14 @@ <bool>true</bool>

</property> </widget> </item> - <item row="13" column="0"> + <item row="14" column="0"> <widget class="QLabel" name="label_25"> <property name="text"> <string>Load extra data:</string> </property> </widget> </item> - <item row="13" column="1"> + <item row="14" column="1"> <widget class="QCheckBox" name="loadStateScreenshot"> <property name="text"> <string>Screenshot</string>

@@ -678,28 +678,28 @@ <bool>true</bool>

</property> </widget> </item> - <item row="14" column="1"> + <item row="15" column="1"> <widget class="QCheckBox" name="loadStateSave"> <property name="text"> <string>Save data</string> </property> </widget> </item> - <item row="15" column="1"> + <item row="16" column="1"> <widget class="QCheckBox" name="loadStateCheats"> <property name="text"> <string>Cheat codes</string> </property> </widget> </item> - <item row="12" column="0" colspan="2"> + <item row="13" column="0" colspan="2"> <widget class="Line" name="line_9"> <property name="orientation"> <enum>Qt::Horizontal</enum> </property> </widget> </item> - <item row="4" column="1"> + <item row="5" column="1"> <widget class="QCheckBox" name="rewindSave"> <property name="text"> <string>Rewind affects save data</string>

@@ -709,10 +709,27 @@ <bool>true</bool>

</property> </widget> </item> - <item row="7" column="1"> + <item row="8" column="1"> <widget class="QCheckBox" name="preload"> <property name="text"> <string>Preload entire ROM into memory</string> + </property> + </widget> + </item> + <item row="1" column="0"> + <widget class="QLabel" name="label_31"> + <property name="text"> + <string>Autofire interval:</string> + </property> + </widget> + </item> + <item row="1" column="1"> + <widget class="QSpinBox" name="autofireThreshold"> + <property name="minimum"> + <number>1</number> + </property> + <property name="maximum"> + <number>60</number> </property> </widget> </item>