all repos — mgba @ 2702dcfb6f83ebb2aae72207b75959f4a639b6ce

mGBA Game Boy Advance Emulator

mGUI: Fix cycling through config setting states with accept button
Vicki Pfau vi@endrift.com
Wed, 14 Oct 2020 23:40:32 -0700
commit

2702dcfb6f83ebb2aae72207b75959f4a639b6ce

parent

2aa39cacbbf28a0866a5a78603007ef659e1f571

2 files changed, 9 insertions(+), 2 deletions(-)

jump to
M CHANGESCHANGES

@@ -78,6 +78,7 @@ - Qt: Load/save bytes from memory viewer in the order visible (fixes mgba.io/i/1900)

- Qt: Fix stride changing when toggling SGB borders (fixes mgba.io/i/1898) - Qt: Fix aliasing on background logo (fixes mgba.io/i/1886) - mGUI: Fix closing down a game if an exit is signalled + - mGUI: Fix cycling through config setting states with accept button - mVL: Fix injecting accidentally draining non-injection buffer - SM83: Simplify register pair access on big endian - SM83: Disassemble STOP as one byte
M src/feature/gui/gui-config.csrc/feature/gui/gui-config.c

@@ -368,8 +368,14 @@ continue;

} #endif if (item->validStates) { - ++item->state; - if (item->state >= item->nStates) { + if (item->state < item->nStates - 1) { + do { + ++item->state; + } while (!item->validStates[item->state] && item->state < item->nStates - 1); + if (!item->validStates[item->state]) { + item->state = 0; + } + } else { item->state = 0; } }