all repos — mgba @ 7395d47a5a17fd8d82eeeb4031d4b92d0b679282

mGBA Game Boy Advance Emulator

Qt: Move message painting into Display
Jeffrey Pfau jeffrey@endrift.com
Thu, 02 Jul 2015 22:17:06 -0700
commit

7395d47a5a17fd8d82eeeb4031d4b92d0b679282

parent

7c629a76bac74d76b1d0564d7507c8a0053bf234

M src/platform/qt/Display.cppsrc/platform/qt/Display.cpp

@@ -50,3 +50,20 @@ {

setSizePolicy(QSizePolicy::MinimumExpanding, QSizePolicy::MinimumExpanding); setMinimumSize(VIDEO_HORIZONTAL_PIXELS, VIDEO_VERTICAL_PIXELS); } + +void Display::resizeEvent(QResizeEvent*) { + m_messagePainter.resize(size(), m_lockAspectRatio); +} + +void Display::lockAspectRatio(bool lock) { + m_lockAspectRatio = lock; + m_messagePainter.resize(size(), m_lockAspectRatio); +} + +void Display::filter(bool filter) { + m_filter = filter; +} + +void Display::showMessage(const QString& message) { + m_messagePainter.showMessage(message); +}
M src/platform/qt/Display.hsrc/platform/qt/Display.h

@@ -8,6 +8,8 @@ #define QGBA_DISPLAY

#include <QWidget> +#include "MessagePainter.h" + struct GBAThread; namespace QGBA {

@@ -28,20 +30,32 @@

static Display* create(QWidget* parent = nullptr); static void setDriver(Driver driver) { s_driver = driver; } + bool isAspectRatioLocked() const { return m_lockAspectRatio; } + bool isFiltered() const { return m_filter; } + public slots: virtual void startDrawing(GBAThread* context) = 0; virtual void stopDrawing() = 0; virtual void pauseDrawing() = 0; virtual void unpauseDrawing() = 0; virtual void forceDraw() = 0; - virtual void lockAspectRatio(bool lock) = 0; - virtual void filter(bool filter) = 0; + virtual void lockAspectRatio(bool lock); + virtual void filter(bool filter); virtual void framePosted(const uint32_t*) = 0; - virtual void showMessage(const QString& message) = 0; + void showMessage(const QString& message); + +protected: + void resizeEvent(QResizeEvent*); + + MessagePainter* messagePainter() { return &m_messagePainter; } private: static Driver s_driver; + + MessagePainter m_messagePainter; + bool m_lockAspectRatio; + bool m_filter; }; }
M src/platform/qt/DisplayGL.cppsrc/platform/qt/DisplayGL.cpp

@@ -19,8 +19,6 @@ : Display(parent)

, m_gl(new EmptyGLWidget(format, this)) , m_painter(new PainterGL(m_gl)) , m_drawThread(nullptr) - , m_lockAspectRatio(false) - , m_filter(false) , m_context(nullptr) { }

@@ -34,6 +32,7 @@ if (m_drawThread) {

return; } m_painter->setContext(thread); + m_painter->setMessagePainter(messagePainter()); m_context = thread; m_painter->resize(size()); m_gl->move(0, 0);

@@ -46,8 +45,8 @@ connect(m_drawThread, SIGNAL(started()), m_painter, SLOT(start()));

m_drawThread->start(); GBASyncSetVideoSync(&m_context->sync, false); - lockAspectRatio(m_lockAspectRatio); - filter(m_filter); + lockAspectRatio(isAspectRatioLocked()); + filter(isFiltered()); resizePainter(); }

@@ -96,14 +95,14 @@ }

} void DisplayGL::lockAspectRatio(bool lock) { - m_lockAspectRatio = lock; + Display::lockAspectRatio(lock); if (m_drawThread) { QMetaObject::invokeMethod(m_painter, "lockAspectRatio", Q_ARG(bool, lock)); } } void DisplayGL::filter(bool filter) { - m_filter = filter; + Display::filter(filter); if (m_drawThread) { QMetaObject::invokeMethod(m_painter, "filter", Q_ARG(bool, filter)); }

@@ -115,13 +114,8 @@ QMetaObject::invokeMethod(m_painter, "setBacking", Q_ARG(const uint32_t*, buffer));

} } -void DisplayGL::showMessage(const QString& message) { - if (m_drawThread) { - QMetaObject::invokeMethod(m_painter, "showMessage", Qt::BlockingQueuedConnection, Q_ARG(const QString&, message)); - } -} - -void DisplayGL::resizeEvent(QResizeEvent*) { +void DisplayGL::resizeEvent(QResizeEvent* event) { + Display::resizeEvent(event); resizePainter(); }

@@ -152,6 +146,10 @@ void PainterGL::setContext(GBAThread* context) {

m_context = context; } +void PainterGL::setMessagePainter(MessagePainter* messagePainter) { + m_messagePainter = messagePainter; +} + void PainterGL::setBacking(const uint32_t* backing) { m_gl->makeCurrent(); m_backend.d.postFrame(&m_backend.d, backing);

@@ -164,7 +162,6 @@

void PainterGL::resize(const QSize& size) { m_size = size; if (m_active) { - m_messagePainter->resize(size, m_backend.d.lockAspectRatio); forceDraw(); } }

@@ -172,7 +169,6 @@

void PainterGL::lockAspectRatio(bool lock) { m_backend.d.lockAspectRatio = lock; if (m_active) { - m_messagePainter->resize(m_size, m_backend.d.lockAspectRatio); forceDraw(); } }

@@ -185,8 +181,6 @@ }

} void PainterGL::start() { - m_messagePainter = new MessagePainter(this); - m_messagePainter->resize(m_size, m_backend.d.lockAspectRatio); m_gl->makeCurrent(); m_backend.d.init(&m_backend.d, reinterpret_cast<WHandle>(m_gl->winId())); m_gl->doneCurrent();

@@ -220,9 +214,6 @@ m_backend.d.swap(&m_backend.d);

m_backend.d.deinit(&m_backend.d); m_gl->doneCurrent(); m_gl->context()->moveToThread(m_gl->thread()); - m_messagePainter->clearMessage(); - delete m_messagePainter; - m_messagePainter = nullptr; moveToThread(m_gl->thread()); }

@@ -243,9 +234,7 @@ float r = m_gl->devicePixelRatio();

m_backend.d.resized(&m_backend.d, m_size.width() * r, m_size.height() * r); m_backend.d.drawFrame(&m_backend.d); m_painter.endNativePainting(); - m_messagePainter->paint(&m_painter); -} - -void PainterGL::showMessage(const QString& message) { - m_messagePainter->showMessage(message); + if (m_messagePainter) { + m_messagePainter->paint(&m_painter); + } }
M src/platform/qt/DisplayGL.hsrc/platform/qt/DisplayGL.h

@@ -8,8 +8,6 @@ #define QGBA_DISPLAY_GL

#include "Display.h" -#include "MessagePainter.h" - #include <QGLWidget> #include <QThread> #include <QTimer>

@@ -49,8 +47,6 @@ void lockAspectRatio(bool lock) override;

void filter(bool filter) override; void framePosted(const uint32_t*) override; - void showMessage(const QString& message) override; - protected: virtual void paintEvent(QPaintEvent*) override {} virtual void resizeEvent(QResizeEvent*) override;

@@ -62,8 +58,6 @@ QGLWidget* m_gl;

PainterGL* m_painter; QThread* m_drawThread; GBAThread* m_context; - bool m_lockAspectRatio; - bool m_filter; }; class PainterGL : public QObject {

@@ -73,6 +67,7 @@ public:

PainterGL(QGLWidget* parent); void setContext(GBAThread*); + void setMessagePainter(MessagePainter*); public slots: void setBacking(const uint32_t*);

@@ -85,8 +80,6 @@ void unpause();

void resize(const QSize& size); void lockAspectRatio(bool lock); void filter(bool filter); - - void showMessage(const QString& message); private: void performDraw();
M src/platform/qt/DisplayQt.cppsrc/platform/qt/DisplayQt.cpp

@@ -16,8 +16,6 @@

DisplayQt::DisplayQt(QWidget* parent) : Display(parent) , m_backing(nullptr) - , m_lockAspectRatio(false) - , m_filter(false) { }

@@ -25,12 +23,12 @@ void DisplayQt::startDrawing(GBAThread*) {

} void DisplayQt::lockAspectRatio(bool lock) { - m_lockAspectRatio = lock; + Display::lockAspectRatio(lock); update(); } void DisplayQt::filter(bool filter) { - m_filter = filter; + Display::filter(filter); update(); }

@@ -48,21 +46,17 @@ #endif

#else m_backing = QImage(reinterpret_cast<const uchar*>(buffer), 256, 256, QImage::Format_RGB32); #endif -} - -void DisplayQt::showMessage(const QString& message) { - m_messagePainter.showMessage(message); } void DisplayQt::paintEvent(QPaintEvent*) { QPainter painter(this); painter.fillRect(QRect(QPoint(), size()), Qt::black); - if (m_filter) { + if (isFiltered()) { painter.setRenderHint(QPainter::SmoothPixmapTransform); } QSize s = size(); QSize ds = s; - if (m_lockAspectRatio) { + if (isAspectRatioLocked()) { if (s.width() * 2 > s.height() * 3) { ds.setWidth(s.height() * 3 / 2); } else if (s.width() * 2 < s.height() * 3) {

@@ -77,9 +71,5 @@ painter.drawImage(full, m_backing, QRect(0, 0, VIDEO_HORIZONTAL_PIXELS, VIDEO_VERTICAL_PIXELS));

#else painter.drawImage(full, m_backing.rgbSwapped(), QRect(0, 0, VIDEO_HORIZONTAL_PIXELS, VIDEO_VERTICAL_PIXELS)); #endif - m_messagePainter.paint(&painter); -} - -void DisplayQt::resizeEvent(QResizeEvent*) { - m_messagePainter.resize(size(), m_lockAspectRatio); + messagePainter()->paint(&painter); }
M src/platform/qt/DisplayQt.hsrc/platform/qt/DisplayQt.h

@@ -7,7 +7,6 @@ #ifndef QGBA_DISPLAY_QT

#define QGBA_DISPLAY_QT #include "Display.h" -#include "MessagePainter.h" #include <QImage> #include <QTimer>

@@ -32,17 +31,11 @@ void lockAspectRatio(bool lock) override;

void filter(bool filter) override; void framePosted(const uint32_t*) override; - void showMessage(const QString& message) override; - protected: virtual void paintEvent(QPaintEvent*) override; - virtual void resizeEvent(QResizeEvent*) override;; private: QImage m_backing; - bool m_lockAspectRatio; - bool m_filter; - MessagePainter m_messagePainter; }; }
M src/platform/qt/MessagePainter.cppsrc/platform/qt/MessagePainter.cpp

@@ -42,7 +42,9 @@ }

m_world.reset(); m_world.translate((w - drawW) / 2, (h - drawH) / 2); m_world.scale(qreal(drawW) / VIDEO_HORIZONTAL_PIXELS, qreal(drawH) / VIDEO_VERTICAL_PIXELS); + m_mutex.lock(); m_message.prepare(m_world, m_messageFont); + m_mutex.unlock(); } void MessagePainter::paint(QPainter* painter) {

@@ -51,6 +53,7 @@ painter->setRenderHint(QPainter::Antialiasing);

painter->setFont(m_messageFont); painter->setPen(Qt::black); painter->translate(1, VIDEO_VERTICAL_PIXELS - m_messageFont.pixelSize() - 1); + m_mutex.lock(); const static int ITERATIONS = 11; for (int i = 0; i < ITERATIONS; ++i) { painter->save();

@@ -60,11 +63,14 @@ painter->restore();

} painter->setPen(Qt::white); painter->drawStaticText(0, 0, m_message); + m_mutex.unlock(); } void MessagePainter::showMessage(const QString& message) { + m_mutex.lock(); m_message.setText(message); m_message.prepare(m_world, m_messageFont); + m_mutex.unlock(); m_messageTimer.stop(); m_messageTimer.start(); }
M src/platform/qt/MessagePainter.hsrc/platform/qt/MessagePainter.h

@@ -6,6 +6,7 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#ifndef QGBA_MESSAGE_PAINTER #define QGBA_MESSAGE_PAINTER +#include <QMutex> #include <QObject> #include <QStaticText> #include <QTimer>

@@ -26,6 +27,7 @@ void showMessage(const QString& message);

void clearMessage(); private: + QMutex m_mutex; QStaticText m_message; QTimer m_messageTimer; QTransform m_world;