all repos — mgba @ a4e105737c43742d3a0e52ba8582730456569488

mGBA Game Boy Advance Emulator

GBA Savedata: Fix save mtime updating when r/o
Vicki Pfau vi@endrift.com
Tue, 08 May 2018 10:20:58 -0700
commit

a4e105737c43742d3a0e52ba8582730456569488

parent

cb180fe717f358ccf63a9103d9e88d6c60365cc5

2 files changed, 9 insertions(+), 6 deletions(-)

jump to
M CHANGESCHANGES

@@ -31,6 +31,7 @@ - GB Timer: Minor accuracy improvements

- GB Audio: Clock frame events on DIV - GBA Timer: Fix timers sometimes being late (fixes mgba.io/i/1012) - GBA Hardware: Fix RTC overriding light sensor (fixes mgba.io/i/1069) + - GBA Savedata: Fix savedata modified time updating when read-only Misc: - GBA Timer: Use global cycles for timers - GBA: Extend oddly-sized ROMs to full address space (fixes mgba.io/i/722)
M src/gba/savedata.csrc/gba/savedata.c

@@ -516,12 +516,14 @@ } else if ((savedata->dirty & SAVEDATA_DIRT_SEEN) && frameCount - savedata->dirtAge > CLEANUP_THRESHOLD) {

if (savedata->maskWriteback) { GBASavedataUnmask(savedata); } - size_t size = GBASavedataSize(savedata); - savedata->dirty = 0; - if (savedata->data && savedata->vf->sync(savedata->vf, savedata->data, size)) { - mLOG(GBA_SAVE, INFO, "Savedata synced"); - } else { - mLOG(GBA_SAVE, INFO, "Savedata failed to sync!"); + if (savedata->mapMode & MAP_WRITE) { + size_t size = GBASavedataSize(savedata); + savedata->dirty = 0; + if (savedata->data && savedata->vf->sync(savedata->vf, savedata->data, size)) { + mLOG(GBA_SAVE, INFO, "Savedata synced"); + } else { + mLOG(GBA_SAVE, INFO, "Savedata failed to sync!"); + } } } }