all repos — mgba @ a510ae8d8650b7d0fd32832a3236c37b5e25c0f6

mGBA Game Boy Advance Emulator

GBA Hardware: Clean up dead code in GBP
Jeffrey Pfau jeffrey@endrift.com
Sat, 17 Sep 2016 11:01:09 -0700
commit

a510ae8d8650b7d0fd32832a3236c37b5e25c0f6

parent

b8f26ebee82b75e6e57ebc405ab07086d3b32281

2 files changed, 1 insertions(+), 11 deletions(-)

jump to
M CHANGESCHANGES

@@ -101,6 +101,7 @@ - Util: Add PRIz macro for libc versions that don't support %z

- SDL: Increase default audio buffer size to 1024 samples - GBA: Add override for Pokemon Pinball: Ruby and Sapphire rumble - SDL: More responsive rumble + - GBA Hardware: Clean up dead code in GBP 0.4.1: (2016-07-11) Bugfixes:
M src/gba/hardware.csrc/gba/hardware.c

@@ -494,16 +494,6 @@ 0x10000010, 0x20000013,

0x30000003 }; -static const uint32_t _gbpRxData[] = { - 0x00000000, 0x494EB6B1, - 0x494EB6B1, 0x544EB6B1, - 0x544EABB1, 0x4E45ABB1, - 0x4E45B1BA, 0x4F44B1BA, - 0x4F44B0BB, 0x8000B0BB, - 0x10000010, 0x20000013, - 0x40000004 -}; - bool GBAHardwarePlayerCheckScreen(const struct GBAVideo* video) { if (memcmp(video->palette, _logoPalette, sizeof(_logoPalette)) != 0) { return false;

@@ -551,7 +541,6 @@ if (address == REG_SIOCNT) {

if (value & 0x0080) { uint32_t rx = gbp->p->p->memory.io[REG_SIODATA32_LO >> 1] | (gbp->p->p->memory.io[REG_SIODATA32_HI >> 1] << 16); if (gbp->p->gbpTxPosition < 12 && gbp->p->gbpTxPosition > 0) { - uint32_t expected = _gbpRxData[gbp->p->gbpTxPosition]; // TODO: Check expected } else if (gbp->p->gbpTxPosition >= 12) { uint32_t mask = 0x33;