GBA Video: Fix effects blending improperly in some non-last windows
Vicki Pfau vi@endrift.com
Tue, 31 Dec 2019 00:20:53 -0800
2 files changed,
3 insertions(+),
1 deletions(-)
M
CHANGES
→
CHANGES
@@ -94,6 +94,7 @@ - GBA DMA: Fix case where DMAs could get misaligned (fixes mgba.io/i/1092)
- GBA Memory: Fix open bus from IWRAM (fixes mgba.io/i/1575) - GBA Video: Fix OpenGL renderer 512x512 backgrounds (fixes mgba.io/i/1572) - GBA Video: Fix BLDY for semitransparent sprite on non-target-2 backgrounds + - GBA Video: Fix effects blending improperly in some non-last windows Other fixes: - 3DS: Fix screen darkening (fixes mgba.io/i/1562) - Core: Fix uninitialized memory issues with graphics caches
M
src/gba/renderers/video-software.c
→
src/gba/renderers/video-software.c
@@ -652,10 +652,11 @@ match |= FLAG_OBJWIN;
} } for (w = 0; w < softwareRenderer->nWindows; ++w) { + int end = softwareRenderer->windows[w].endX; if (!GBAWindowControlIsBlendEnable(softwareRenderer->windows[w].control.packed)) { + x = end; continue; } - int end = softwareRenderer->windows[w].endX; if (softwareRenderer->blendEffect == BLEND_DARKEN) { for (; x < end; ++x) { uint32_t color = softwareRenderer->row[x];