all repos — mgba @ e582e98b62299eb1b90ff438cdd2fd299671ba07

mGBA Game Boy Advance Emulator

GBA Video: Fix mosaic objects drawing past the end (fixes #1702)
Vicki Pfau vi@endrift.com
Wed, 13 May 2020 23:31:44 -0700
commit

e582e98b62299eb1b90ff438cdd2fd299671ba07

parent

ba11b8aa0cd8dca77efcd12913bbbfa74f69b04d

2 files changed, 2 insertions(+), 1 deletions(-)

jump to
M CHANGES → CHANGES 
@@ -6,6 +6,7 @@ - GBA: Add missing RTC overrides for Legendz games
  - GBA SIO: Fix Multiplayer busy bit
  - GBA SIO: Fix double-unloading active driver
  - GBA Timers: Fix deserializing count-up timers
+ - GBA Video: Fix mosaic objects drawing past the end (fixes mgba.io/i/1702)
 Other fixes:
  - Core: Fix ELF loading regression (fixes mgba.io/i/1669)
  - Core: Fix crash modifying hash table entry (fixes mgba.io/i/1673)
M src/gba/renderers/software-obj.c → src/gba/renderers/software-obj.c 
@@ -224,7 +224,7 @@ }
 		int mosaicH = 1;
 		if (GBAObjAttributesAIsMosaic(sprite->a)) {
 			mosaicH = GBAMosaicControlGetObjH(renderer->mosaic) + 1;
-			if (condition % mosaicH) {
+			if (condition != end && condition % mosaicH) {
 				condition += mosaicH - (condition % mosaicH);
 			}
 		}