all repos — mgba @ f4abdd6c4c475c5249754d184abc9c42d63c24b0

mGBA Game Boy Advance Emulator

GBA BIOS: Fix ArcTan2 sign in HLE BIOS (fixes #689)
Vicki Pfau vi@endrift.com
Thu, 20 Apr 2017 17:59:02 -0700
commit

f4abdd6c4c475c5249754d184abc9c42d63c24b0

parent

c9d411a762ec6ef13c3108d0479408f8326df442

2 files changed, 4 insertions(+), 3 deletions(-)

jump to
M CHANGES → CHANGES 
@@ -39,6 +39,7 @@ - GB: Fix flickering when screen is strobed quickly
  - FFmpeg: Fix overflow and general issues with audio encoding
  - Qt: Fix crash when changing audio settings after a game is closed
  - GBA BIOS: Fix ArcTan sign in HLE BIOS
+ - GBA BIOS: Fix ArcTan2 sign in HLE BIOS
 Misc:
  - SDL: Remove scancode key input
  - GBA Video: Clean up unused timers
M src/gba/bios.c → src/gba/bios.c 
@@ -283,7 +283,7 @@ b = ((b * a) >> 14) + 0xA2F9;
 	return (i * b) >> 16;
 }
 
-static int16_t _ArcTan2(int16_t x, int16_t y) {
+static int16_t _ArcTan2(int32_t x, int32_t y) {
 	if (!y) {
 		if (x >= 0) {
 			return 0;

@@ -299,7 +299,7 @@ }
 	if (y >= 0) {
 		if (x >= 0) {
 			if (x >= y) {
-				return _ArcTan((y << 14)/ x);
+				return _ArcTan((y << 14) / x);
 			}
 		} else if (-x >= y) {
 			return _ArcTan((y << 14) / x) + 0x8000;

@@ -359,7 +359,7 @@ case 0x9:
 		cpu->gprs[0] = _ArcTan(cpu->gprs[0]);
 		break;
 	case 0xA:
-		cpu->gprs[0] = (uint16_t) _ArcTan2(cpu->gprs[0], cpu->gprs[1]);
+		cpu->gprs[0] = _ArcTan2(cpu->gprs[0], cpu->gprs[1]);
 		break;
 	case 0xB:
 	case 0xC: