all repos — mgba @ fb939ab0426966089f4120eeff258ca1b3787256

mGBA Game Boy Advance Emulator

GB MBC: Remove erroneous bank 0 wrapping
Vicki Pfau vi@endrift.com
Sun, 05 Nov 2017 21:05:06 -0800
commit

fb939ab0426966089f4120eeff258ca1b3787256

parent

7fd3eb722bc6fd993f1df4c9e81c16f3c101f245

6 files changed, 1 insertions(+), 6 deletions(-)

jump to
M CHANGES → CHANGES 
@@ -38,6 +38,7 @@ - GBA: Implement display start DMAs
  - Qt: Prevent window from being created off-screen
  - Qt: Add option to disable FPS display
  - GBA: Improve multiboot image detection
+ - GB MBC: Remove erroneous bank 0 wrapping
 
 0.6.1: (2017-10-01)
 Bugfixes:
D cinema/gb/mooneye-gb/emulator-only/mbc1/rom_1Mb/manifest.yml 
@@ -1,1 +0,0 @@
-fail: true
D cinema/gb/mooneye-gb/emulator-only/mbc1/rom_2Mb/manifest.yml 
@@ -1,1 +0,0 @@
-fail: true
D cinema/gb/mooneye-gb/emulator-only/mbc1_rom_4banks/manifest.yml 
@@ -1,1 +0,0 @@
-fail: true
M src/gb/mbc.c → src/gb/mbc.c 
@@ -45,9 +45,6 @@ if (bankStart + GB_SIZE_CART_BANK0 > gb->memory.romSize) {
 		mLOG(GB_MBC, GAME_ERROR, "Attempting to switch to an invalid ROM bank: %0X", bank);
 		bankStart &= (gb->memory.romSize - 1);
 		bank = bankStart / GB_SIZE_CART_BANK0;
-		if (!bank) {
-			++bank;
-		}
 	}
 	gb->memory.romBank = &gb->memory.rom[bankStart];
 	gb->memory.currentBank = bank;