all repos — mgba @ 7f9c7706bcc8b9f2b251e4d784e4df8cdda8f122

mGBA Game Boy Advance Emulator

GB MBC: Remove erroneous bank 0 wrapping
Vicki Pfau vi@endrift.com
Sun, 05 Nov 2017 21:05:06 -0800
commit

7f9c7706bcc8b9f2b251e4d784e4df8cdda8f122

parent

5522286c57a664e9d84c26f72fd5506e5ac08fe8

2 files changed, 1 insertions(+), 3 deletions(-)

jump to
M CHANGES → CHANGES 
@@ -8,6 +8,7 @@ - GBA Video: OBJWIN can change blend params after OBJ is drawn (fixes mgba.io/i/921)
  - GBA Savedata: Fix crash when resizing flash
 Misc:
  - GBA: Improve multiboot image detection
+ - GB MBC: Remove erroneous bank 0 wrapping
 
 0.6.1: (2017-10-01)
 Bugfixes:
M src/gb/mbc.c → src/gb/mbc.c 
@@ -39,9 +39,6 @@ if (bankStart + GB_SIZE_CART_BANK0 > gb->memory.romSize) {
 		mLOG(GB_MBC, GAME_ERROR, "Attempting to switch to an invalid ROM bank: %0X", bank);
 		bankStart &= (gb->memory.romSize - 1);
 		bank = bankStart / GB_SIZE_CART_BANK0;
-		if (!bank) {
-			++bank;
-		}
 	}
 	gb->memory.romBank = &gb->memory.rom[bankStart];
 	gb->memory.currentBank = bank;